Fix tincture effect calculation for imported tinctures#9039
Open
Kojoley wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Fix tincture effect calculation for imported tinctures#9039Kojoley wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Kojoley wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Recalculate tincture effect from tincture quality and local increased effect mod only when a tincture is marked as crafted. Fixes PathOfBuildingCommunity#8039 Fixes PathOfBuildingCommunity#8090
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recalculate tincture effect from tincture quality and local increased effect mod only when a tincture is marked as crafted.
This is a hacky workaround, but nothing better comes to my mind.
Fixes #8039
Fixes #8090
Description of the problem being solved:
POB applies local increased effect to imported tinctures where local increased effect is already applied.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: